Remove config key normalization #4742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we'd normalize all key names in dask.config to hyphenated names, replacing all underscores with hyphens. This causes problems with keys that should be taken as literal values (e.g. environment variables in an env key). We now keep the user-facing functions (e.g. ``get``, ``set``, etc...) agnostic to hyphen/underscores, but leave new keys unchanged. This has the nice property that once a key is in the config it can be looked up or changed by any provided name, but new keys (which may potentially be data instead of config names) are unchanged.
2 tasks
|
cc @djhoese |
djhoese
pushed a commit
to djhoese/donfig
that referenced
this pull request
Apr 27, 2019
Original changes by @jcrist, adapted for donfig. See dask/dask#4742 for details.
|
Planning on merging tomorrow if no comment. |
quasiben
reviewed
Apr 30, 2019
dask/config.py
Outdated
| def canonical_name(k, config): | ||
| """Return the canonical name for a key. | ||
|
|
||
| Handles user choose of '-' or '_' conventions by standardizing on whichever |
|
Merging. |
|
These changes have been ported to the |
jorge-pessoa
pushed a commit
to jorge-pessoa/dask
that referenced
this pull request
May 14, 2019
* Remove config key normalization Previously we'd normalize all key names in dask.config to hyphenated names, replacing all underscores with hyphens. This causes problems with keys that should be taken as literal values (e.g. environment variables in an env key). We now keep the user-facing functions (e.g. ``get``, ``set``, etc...) agnostic to hyphen/underscores, but leave new keys unchanged. This has the nice property that once a key is in the config it can be looked up or changed by any provided name, but new keys (which may potentially be data instead of config names) are unchanged. * Type [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we'd normalize all key names in dask.config to hyphenated
names, replacing all underscores with hyphens. This causes problems with
keys that should be taken as literal values (e.g. environment variables
in an env key).
We now keep the user-facing functions (e.g.
get,set, etc...)agnostic to hyphen/underscores, but leave new keys unchanged. This has
the nice property that once a key is in the config it can be looked up
or changed by any provided name, but new keys (which may potentially be
data instead of config names) are unchanged.
Supersedes #4422.
Fixes #4366.